Skip to content

Make uploadSslCert a POST request instead of a GET - #2661

Merged
yadvr merged 1 commit into
apache:4.11from
GabrielBrascher:issue2558ApiUploadSslCertDoesNotWork
May 23, 2018
Merged

yadvr merged 1 commit into
apache:4.11from
GabrielBrascher:issue2558ApiUploadSslCertDoesNotWork

Conversation

@GabrielBrascher

Copy link
Copy Markdown
Member

If the Request Header Size grows (for instance a cert chain of 8kb) it will fail to upload the SSL Cert.

This problem was raised on the issue 2558

Description

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@yadvr

yadvr commented May 23, 2018

Copy link
Copy Markdown
Member

Lgtm, UI fix. Will merge.

@yadvr
yadvr merged commit eb23d91 into apache:4.11 May 23, 2018
yadvr added a commit that referenced this pull request May 23, 2018
ui: Fixes #2558 use POST for uploadSslCert API request (#2661)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants